Skip to content

🐞 Fix LazyShuffler.grow length validation - #1549

Open
atarpara wants to merge 1 commit into
mainfrom
fix-lazyshuffler
Open

🐞 Fix LazyShuffler.grow length validation#1549
atarpara wants to merge 1 commit into
mainfrom
fix-lazyshuffler

Conversation

@atarpara

Copy link
Copy Markdown
Collaborator

Description

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions

Copy link
Copy Markdown

Gas Snapshot Comparison Report

Generated at commit : c2f7b56, Compared to commit : 4225d5f

Contract Name Test Name Main Gas PR Gas Diff
LibPRNGTest testLCGGas() 20800 20778 -22
testLazyShufflerGet() 298435 298479 44
testLazyShufflerNoStorageCollisions() 265037 265082 45
testLazyShufflerProducesShuffledRange2() 9038738 9038716 -22
testLazyShufflerRestart() 274986 275009 23
testLazyShufflerRevertsOnDoubleInit() 71218 71230 12
testLazyShufflerRevertsOnZeroLengthNext() 49851 49940 89
testPRNGNext() 16160 16226 66
testPRNGPartialShuffleDistribution() 7688699 7688656 -43
testPRNGShuffle() 712273 712296 23
testPRNGShuffleBytes() 217417 217395 -22
testPRNGShuffleDistribution() 3088846 3088824 -22
testPRNGShuffleGas() 1610923 1610968 45
testStandardNormalWad() 4422897 4422920 23
test__codesize() 14379 15531 1152
testLazyShufflerGrowWithinSameWidth() - 47283 -
testLazyShufflerGrowWithinWideWidth() - 69203 -
testLazyShufflerRevertsOnGrowAcrossWidthBoundary() - 72845 -
testLazyShufflerRevertsOnGrowAcrossWidthBoundaryUndrawn() - 49408 -
testLazyShufflerWideProducesNoDuplicatesAcrossGrow() - 262975 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant